Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enrich events with information #452

Merged
merged 49 commits into from
Jun 15, 2021
Merged

Feature: Enrich events with information #452

merged 49 commits into from
Jun 15, 2021

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented May 4, 2021

📜 Description

Enrich events with information

💡 Motivation and Context

Closes #315
Closes #262

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #452 (e6beee4) into main (6873600) will decrease coverage by 0.04%.
The diff coverage is 91.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   91.24%   91.20%   -0.05%     
==========================================
  Files          63       66       +3     
  Lines        2091     2216     +125     
==========================================
+ Hits         1908     2021     +113     
- Misses        183      195      +12     
Impacted Files Coverage Δ
...tter/lib/src/flutter_enricher_event_processor.dart 87.50% <87.50%> (ø)
.../lib/src/enricher/io_enricher_event_processor.dart 90.47% <90.47%> (ø)
dart/lib/src/protocol/sentry_device.dart 99.37% <96.96%> (-0.63%) ⬇️
...art/lib/src/enricher/enricher_event_processor.dart 100.00% <100.00%> (ø)
dart/lib/src/platform_checker.dart 62.50% <100.00%> (ø)
dart/lib/src/protocol/sentry_runtime.dart 100.00% <100.00%> (ø)
dart/lib/src/sentry.dart 88.88% <100.00%> (+0.17%) ⬆️
flutter/lib/src/sentry_flutter.dart 100.00% <100.00%> (+5.40%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6873600...e6beee4. Read the comment docs.

dart/lib/src/enricher/_io_enricher.dart Outdated Show resolved Hide resolved
dart/lib/src/enricher/_io_enricher.dart Outdated Show resolved Hide resolved
dart/lib/src/enricher/_web_enricher.dart Outdated Show resolved Hide resolved
dart/lib/src/enricher/_io_enricher.dart Outdated Show resolved Hide resolved
flutter/lib/src/flutter_enricher.dart Outdated Show resolved Hide resolved
flutter/pubspec.yaml Outdated Show resolved Hide resolved
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has so much great information. I'd love to see what this looks like in Sentry. Care to attach a screenshot?

dart/lib/src/enricher/_io_enricher.dart Outdated Show resolved Hide resolved
dart/lib/src/enricher/_io_enricher.dart Outdated Show resolved Hide resolved
dart/lib/src/enricher/_io_enricher.dart Outdated Show resolved Hide resolved
dart/lib/src/enricher/_io_enricher.dart Outdated Show resolved Hide resolved
dart/lib/src/enricher/_web_enricher.dart Outdated Show resolved Hide resolved
flutter/example/lib/main.dart Outdated Show resolved Hide resolved
flutter/lib/src/flutter_enricher.dart Outdated Show resolved Hide resolved
flutter/pubspec.yaml Outdated Show resolved Hide resolved
@ueman ueman force-pushed the feature/enricher branch from 320f386 to 54d16ea Compare May 6, 2021 07:36
@ueman
Copy link
Collaborator Author

ueman commented May 6, 2021

This has so much great information. I'd love to see what this looks like in Sentry. Care to attach a screenshot?

https://sentry.io/share/issue/8215a456950349b48031230203c4b9de/
Well it's not a screenshot but I guess it works too.
This is what it currently looks like on Flutter for Web

@ueman
Copy link
Collaborator Author

ueman commented May 7, 2021

This is what it looks like on Ubuntu (without device info):
https://sentry.io/share/issue/025c1729f3194e0e8ec3b4ef72c84b03/

@bruno-garcia

This comment has been minimized.

@ueman

This comment has been minimized.

dart/lib/src/enricher/_web_enricher.dart Outdated Show resolved Hide resolved
flutter/lib/src/flutter_enricher.dart Outdated Show resolved Hide resolved
@ueman

This comment has been minimized.

@ueman
Copy link
Collaborator Author

ueman commented Jun 7, 2021

I would like to build on #489 and #491

@ueman ueman requested a review from marandaneto June 11, 2021 12:20
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueman ueman merged commit b9866b7 into main Jun 15, 2021
@ueman ueman deleted the feature/enricher branch June 15, 2021 07:50
@venkatd
Copy link

venkatd commented Jul 6, 2021

@ueman does this code run for you on debug mode with Flutter web? For me the whole browser crashes so I've had to downgrade to 5.1.0. If it runs for you without problems, I can try to share a reproduction.

@ueman
Copy link
Collaborator Author

ueman commented Jul 7, 2021

@ueman does this code run for you on debug mode with Flutter web? For me the whole browser crashes so I've had to downgrade to 5.1.0. If it runs for you without problems, I can try to share a reproduction.

Are you talking about #521 or something else? If it's not #521 I appreciate a reproduction. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web missing OS/Device/Browser info Flutter Web/Desktop missing OS/Device/Browser info
7 participants