-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Enrich events with information #452
Conversation
Codecov Report
@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 91.24% 91.20% -0.05%
==========================================
Files 63 66 +3
Lines 2091 2216 +125
==========================================
+ Hits 1908 2021 +113
- Misses 183 195 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has so much great information. I'd love to see what this looks like in Sentry. Care to attach a screenshot?
https://sentry.io/share/issue/8215a456950349b48031230203c4b9de/ |
This is what it looks like on Ubuntu (without device info): |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # flutter/example/lib/main.dart
# Conflicts: # dart/lib/src/protocol/sentry_device.dart # dart/lib/src/protocol/sentry_runtime.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ueman does this code run for you on debug mode with Flutter web? For me the whole browser crashes so I've had to downgrade to |
Are you talking about #521 or something else? If it's not #521 I appreciate a reproduction. Thanks! |
📜 Description
Enrich events with information
💡 Motivation and Context
Closes #315
Closes #262
💚 How did you test it?
📝 Checklist
🔮 Next steps
Compiler
orruntime type
field for Runtimes (AOT, VM, dart2js, dartdevc)