-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SentryFeedbackWidget
#2240
Add SentryFeedbackWidget
#2240
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/capture-feedback #2240 +/- ##
=========================================================
+ Coverage 88.03% 90.92% +2.88%
=========================================================
Files 248 74 -174
Lines 8653 2468 -6185
=========================================================
- Hits 7618 2244 -5374
+ Misses 1035 224 -811 ☔ View full report in Codecov by Sentry. |
Maybe the screenshot can be taken right before the feedback form is triggered? It could work something like this: Future<void> showSentryFeedbackForm(BuildContext context) {
await takeScreenshot();
await Navigator.push(
context,
MaterialPageRoute(
builder: (context) => SentryFeedbackWidget(associatedEventId: id),
fullscreenDialog: true,
),
);
} This follows the patter as to what Flutter provides out of the box with I doubt it's possible to do while the feedback from is active, since the form would be captured by the screenshot widget too. |
afaik js browser sdk doesn't support screenshots, don't we support screenshot on web anyway? |
# Conflicts: # flutter/example/lib/user_feedback_dialog.dart # flutter/test/mocks.mocks.dart
@ueman I will merge this PR into the other. Let's tackle auto-screenshots in another PR. |
* add captureFeedback methods * add should capture feedback as event test * add sentry_feedback_test * update contexts test * test before send feedback * test hint and event processors * basic scope test * test trace context and attachment behaviour * test sample rate for feedback and fix mock transport calls comparison * add hub tests * add sentry tests * add changelog entry * cleanup + comments * test envelope item for feedback * remove duplacte typedef * fix test expectation * Deprecate captureUserFeedback * update depraction info in cl * format * add missing option in test * run format * organize imports * add missing method * fix test epectation * ignore deprecations internally * add to integration test, fix analyze errors * fix cl * disable fixture.options.automatedTestMode * update test * fix cl * Add `SentryFeedbackWidget` (#2240) * fix cl * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
📜 Description
flutter
package💡 Motivation and Context
Relates to #1593
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
With
sentry-javascrip
we can also add a screenshot of the browser window as an attachment. What makes sense here?