Discard empty stack frames

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Normalize data properties of `SentryUser` and `Breadcrumb` before sending over method channel ([#1591](https://github.com/getsentry/sentry-dart/pull/1591))
 - Fixing memory leak issue in SentryFlutterPlugin (Android Plugin) ([#1588](https://github.com/getsentry/sentry-dart/pull/1588))
+- Discard empty stack frames ([#1625](https://github.com/getsentry/sentry-dart/pull/1625))
 
 ### Dependencies
 

dio/test/dio_event_processor_test.dart

@@ -67,7 +67,7 @@ void main() {
         throwable: throwable,
         exceptions: [
           fixture.sentryError(throwable),
-          fixture.sentryError(dioError)
+          fixture.sentryError(dioError),
         ],
       );
       final processedEvent = sut.apply(event) as SentryEvent;
@@ -96,7 +96,7 @@ void main() {
         throwable: throwable,
         exceptions: [
           fixture.sentryError(throwable),
-          fixture.sentryError(dioError)
+          fixture.sentryError(dioError),
         ],
       );
       final processedEvent = sut.apply(event) as SentryEvent;
@@ -125,7 +125,7 @@ void main() {
         throwable: throwable,
         exceptions: [
           fixture.sentryError(throwable),
-          fixture.sentryError(dioError)
+          fixture.sentryError(dioError),
         ],
       );
       final processedEvent = sut.apply(event) as SentryEvent;
@@ -177,7 +177,7 @@ void main() {
           throwable: throwable,
           exceptions: [
             fixture.sentryError(throwable),
-            fixture.sentryError(dioError)
+            fixture.sentryError(dioError),
           ],
         );
         final processedEvent = sut.apply(event) as SentryEvent;
@@ -207,7 +207,7 @@ void main() {
           data: 'foobar',
           headers: Headers.fromMap(<String, List<String>>{
             'foo': ['bar'],
-            'set-cookie': ['foo=bar']
+            'set-cookie': ['foo=bar'],
           }),
           requestOptions: request,
           isRedirect: true,
@@ -219,7 +219,7 @@ void main() {
         throwable: throwable,
         exceptions: [
           fixture.sentryError(throwable),
-          fixture.sentryError(dioError)
+          fixture.sentryError(dioError),
         ],
       );
       final processedEvent = sut.apply(event) as SentryEvent;
@@ -248,7 +248,7 @@ void main() {
         response: Response<dynamic>(
           data: 'foobar',
           headers: Headers.fromMap(<String, List<String>>{
-            'foo': ['bar']
+            'foo': ['bar'],
           }),
           requestOptions: request,
           isRedirect: true,
@@ -260,7 +260,7 @@ void main() {
         throwable: throwable,
         exceptions: [
           fixture.sentryError(throwable),
-          fixture.sentryError(dioError)
+          fixture.sentryError(dioError),
         ],
       );
       final processedEvent = sut.apply(event) as SentryEvent;
@@ -320,7 +320,7 @@ void main() {
           throwable: throwable,
           exceptions: [
             fixture.sentryError(throwable),
-            fixture.sentryError(dioError)
+            fixture.sentryError(dioError),
           ],
         );
         final processedEvent = sut.apply(event) as SentryEvent;
@@ -338,7 +338,7 @@ void main() {
       final dataByType = {
         ResponseType.plain: ['plain'],
         ResponseType.bytes: [
-          [1337]
+          [1337],
         ],
         ResponseType.json: [
           9001,
@@ -347,7 +347,7 @@ void main() {
           true,
           ['list'],
           {'map-key': 'map-value'},
-        ]
+        ],
       };
 
       for (final entry in dataByType.entries) {
@@ -375,7 +375,7 @@ void main() {
             throwable: throwable,
             exceptions: [
               fixture.sentryError(throwable),
-              fixture.sentryError(dioError)
+              fixture.sentryError(dioError),
             ],
           );
           final processedEvent = sut.apply(event) as SentryEvent;

dio/test/failed_request_interceptor_test.dart

@@ -113,7 +113,7 @@ class Fixture {
 
   FailedRequestInterceptor getSut({
     List<SentryStatusCode> failedRequestStatusCodes = const [
-      SentryStatusCode.defaultRange()
+      SentryStatusCode.defaultRange(),
     ],
     List<String> failedRequestTargets = const ['.*'],
   }) {

dio/test/mocks.dart

@@ -42,7 +42,7 @@ final fakeEvent = SentryEvent(
       type: 'navigation',
       data: <String, dynamic>{'screen': 'MainActivity', 'state': 'created'},
       level: SentryLevel.info,
-    )
+    ),
   ],
   contexts: Contexts(
     operatingSystem: const SentryOperatingSystem(

flutter/lib/src/jvm/jvm_exception.dart

@@ -256,8 +256,11 @@ class JvmException {
       frames.add(trimmed);
     }
 
-    final thisExceptionFrames =
-        thisException.map((e) => JvmFrame.parse(e)).toList(growable: false);
+    final thisExceptionFrames = thisException
+        .map((e) => JvmFrame.parse(e))
+        .where(
+            (e) => e.originalFrame.isNotEmpty && e.originalFrame.trim() != 'at')
+        .toList(growable: false);
 
     final suppressedExceptions = supressed
         .map((e) => JvmException.parse(e.join(_newLine)))

flutter/test/jvm/jvm_exception_test.dart

@@ -40,7 +40,7 @@ void main() {
         'Violation of unique constraint MY_ENTITY_UK_1: duplicate value(s) for column(s) MY_COLUMN in statement [...]');
     expect(thirdCause.thread, null);
     expect(thirdCause.type, 'java.sql.SQLException');
-    expect(thirdCause.stackTrace.length, 6);
+    expect(thirdCause.stackTrace.length, 5);
     expect(thirdCause.causes, null);
     expect(thirdCause.suppressed, null);
   });
@@ -85,6 +85,16 @@ void main() {
     expect(exception.stackTrace[0].fileName, 'StandardMessageCodec.java');
     expect(exception.stackTrace[0].lineNumber, 292);
   });
+
+  test('parse drops frames with `at ` and empty original frame', () {
+    final exception = JvmException.parse(platformExceptionWithEmptyStackFrames);
+    expect(exception.stackTrace.length, 13);
+    expect(exception.stackTrace.last.className,
+        'com.android.internal.os.ZygoteInit');
+    expect(exception.stackTrace.last.fileName, 'ZygoteInit.java');
+    expect(exception.stackTrace.last.method, 'main');
+    expect(exception.stackTrace.last.lineNumber, 936);
+  });
 }
 
 const javaExceptionWithCauses = '''
@@ -194,3 +204,21 @@ java.lang.IllegalArgumentException: Unsupported value: '[Ljava.lang.StackTraceEl
 	at java.lang.reflect.Method.invoke(Native Method)
 	at com.android.internal.os.RuntimeInit\$MethodAndArgsCaller.run(RuntimeInit.java:556)
 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1037)''';
+
+const platformExceptionWithEmptyStackFrames = '''
+java.lang.RuntimeException: Catch this platform exception!
+    at io.sentry.samples.flutter.MainActivity\$configureFlutterEngine\$1.onMethodCall(MainActivity.kt:40)
+    at io.flutter.plugin.common.MethodChannel\$IncomingMethodCallHandler.onMessage(MethodChannel.java:258)
+    at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)
+    at io.flutter.embedding.engine.dart.DartMessenger.lambda\$dispatchMessageToQueue\$0\$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:322)
+    at io.flutter.embedding.engine.dart.DartMessenger\$\$ExternalSyntheticLambda0.run(Unknown Source:12)
+    at android.os.Handler.handleCallback(Handler.java:942)
+    at android.os.Handler.dispatchMessage(Handler.java:99)
+    at android.os.Looper.loopOnce(Looper.java:201)
+    at android.os.Looper.loop(Looper.java:288)
+    at android.app.ActivityThread.main(ActivityThread.java:7872)
+    at java.lang.reflect.Method.invoke
+    at com.android.internal.os.RuntimeInit\$MethodAndArgsCaller.run(RuntimeInit.java:548)
+    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
+    at
+    ''';

sqflite/test/mocks/mocks.dart

@@ -33,7 +33,8 @@ ISentrySpan startTransactionShim(
     DatabaseExecutor,
   ],
   customMocks: [
-    MockSpec<Hub>(fallbackGenerators: {#startTransaction: startTransactionShim})
+    MockSpec<Hub>(
+        fallbackGenerators: {#startTransaction: startTransactionShim}),
   ],
 )
 void main() {}