Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove split-debug-info limitation from readme #1313

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

marandaneto
Copy link
Contributor

📜 Description

#skip-changelog

💡 Motivation and Context

Relates to #1281

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.90 🎉

Comparison is base (f96ca24) 89.82% compared to head (0a11830) 92.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   89.82%   92.73%   +2.90%     
==========================================
  Files         155       34     -121     
  Lines        5063     1253    -3810     
==========================================
- Hits         4548     1162    -3386     
+ Misses        515       91     -424     
Impacted Files Coverage Δ
dio/lib/src/failed_request_interceptor.dart
dart/lib/src/transport/data_category.dart
dart/lib/src/client_reports/client_report.dart
...art/lib/src/environment/environment_variables.dart
dart/lib/src/sentry_user_feedback.dart
dart/lib/src/protocol/max_body_size.dart
dart/lib/src/utils/tracing_utils.dart
dart/lib/src/protocol/sentry_message.dart
dart/lib/src/hub_adapter.dart
dart/lib/src/sentry_envelope_item_header.dart
... and 111 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 338.17 ms 427.51 ms 89.34 ms
Size 6.06 MiB 7.10 MiB 1.04 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
69670c9 325.59 ms 385.82 ms 60.22 ms
2d3b03d 309.53 ms 353.40 ms 43.87 ms
e66e71e 296.84 ms 345.43 ms 48.59 ms
2f8f173 323.31 ms 373.29 ms 49.97 ms
ef31c7f 311.39 ms 359.33 ms 47.94 ms
134c9f8 301.40 ms 352.65 ms 51.26 ms
3e9fb0e 329.14 ms 359.16 ms 30.02 ms
379d7a8 327.10 ms 355.39 ms 28.29 ms
deaeece 347.42 ms 381.10 ms 33.68 ms
5603ab2 309.84 ms 345.20 ms 35.36 ms

App size

Revision Plain With Sentry Diff
69670c9 6.06 MiB 7.09 MiB 1.03 MiB
2d3b03d 6.06 MiB 7.09 MiB 1.03 MiB
e66e71e 6.06 MiB 7.09 MiB 1.03 MiB
2f8f173 5.94 MiB 6.95 MiB 1.01 MiB
ef31c7f 6.06 MiB 7.09 MiB 1.03 MiB
134c9f8 5.94 MiB 6.95 MiB 1.01 MiB
3e9fb0e 5.94 MiB 6.95 MiB 1.01 MiB
379d7a8 5.94 MiB 6.95 MiB 1.01 MiB
deaeece 5.94 MiB 6.96 MiB 1.02 MiB
5603ab2 5.94 MiB 6.95 MiB 1.01 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1254.56 ms 1266.80 ms 12.23 ms
Size 8.10 MiB 9.08 MiB 1004.35 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ef31c7f 1272.43 ms 1295.71 ms 23.29 ms
ecb4003 1266.94 ms 1290.24 ms 23.31 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms
21845e2 1279.37 ms 1298.81 ms 19.45 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
d7758e8 1271.69 ms 1288.08 ms 16.39 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
691aa3b 1265.57 ms 1282.13 ms 16.55 ms
8fa3934 1252.79 ms 1272.41 ms 19.62 ms
379d7a8 1267.65 ms 1288.39 ms 20.74 ms

App size

Revision Plain With Sentry Diff
ef31c7f 8.09 MiB 9.07 MiB 1000.79 KiB
ecb4003 8.09 MiB 9.07 MiB 1000.82 KiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
d7758e8 8.15 MiB 9.12 MiB 989.76 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
691aa3b 8.16 MiB 9.17 MiB 1.01 MiB
8fa3934 8.09 MiB 9.07 MiB 1000.86 KiB
379d7a8 8.16 MiB 9.16 MiB 1.00 MiB

@marandaneto marandaneto merged commit b49bf00 into main Mar 6, 2023
@marandaneto marandaneto deleted the fix/remove-split-debug-info-limitation branch March 6, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants