Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set client name with version in sentry-android #1274

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Feb 8, 2023

📜 Description

sentry_client should include the version
https://develop.sentry.dev/sdk/overview/#authentication

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 90.21% // Head: 90.21% // No change to project coverage 👍

Coverage data is based on head (2fd5fb4) compared to base (a3cc064).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           v7.0.0    #1274   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files         164      164           
  Lines        5143     5143           
=======================================
  Hits         4640     4640           
  Misses        503      503           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krystofwoldrich krystofwoldrich marked this pull request as ready for review February 8, 2023 14:59
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @krystofwoldrich

@marandaneto marandaneto merged commit c1514a7 into v7.0.0 Feb 8, 2023
@marandaneto marandaneto deleted the set-client-name-with-version-android branch February 8, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants