-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set client name with version in sentry-android #1274
Conversation
Codecov ReportBase: 90.21% // Head: 90.21% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1274 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 164 164
Lines 5143 5143
=======================================
Hits 4640 4640
Misses 503 503 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
…rPlugin.kt Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
…h-version-android
…roid' into set-client-name-with-version-android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @krystofwoldrich
📜 Description
sentry_client
should include the versionhttps://develop.sentry.dev/sdk/overview/#authentication
💡 Motivation and Context
sentryClientName
on Native SDKs during SDK init. team-mobile#48💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps