-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Migrate to sentry cocoa v8 #1197
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1197 +/- ##
=========================================
Coverage ? 89.90%
=========================================
Files ? 120
Lines ? 3684
Branches ? 0
=========================================
Hits ? 3312
Misses ? 372
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
flutter/test/integrations/init_native_sdk_integration_test.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # flutter/ios/sentry_flutter.podspec
@denrase I have changed to 8.0.0-rc.1 @brustolin and @philipphofmann would you be kind to review this as well? thanks. |
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Show resolved
Hide resolved
The configuration changes in the migration docs should be fixed I guess https://github.com/getsentry/sentry-docs/pull/5939/files |
All the breaking changes are in the Changelog. The migration docs are also almost ready. I have still a PR open for the final touches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have many more breaking changes in the Changelog. I would be surprised if you don't need more changes in this PR.
I would expect the following changes to bubble up here
- Rename APM tracking feature flags to tracing (Ignore Flutter Web source context error in Sentry Frontend for internal dart files #2450)
- Rename
SentryOptions.enableAutoPerformanceTracking
toenableAutoPerformanceTracing
- Rename
SentryOptions.enableUIViewControllerTracking
toenableUIViewControllerTracing
- Rename
SentryOptions.enablePreWarmedAppStartTracking
toenablePreWarmedAppStartTracing
- Rename
SentryOptions.enableFileIOTracking
toenableFileIOTracing
- Rename
SentryOptions.enableCoreDataTracking
toenableCoreDataTracing
- Rename
- Rename
SentryOptions.enableOutOfMemoryTracking
toSentryOptions.enableWatchdogTerminationTracking
(SentryFlutter.Init will block the main thread in Profile/Release mode of version 8.11.0 #2499)
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Show resolved
Hide resolved
#1222 has fixes that are needed for this PR, this PR also has this PR as the target branch, maybe we merge it? |
…ry/sentry-dart into chore/migrate-to-sentry-cocoa-v8
@marandaneto CI seems happy now. Rdy for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments, but other than that, LGTM.
📜 Description
Closes #1161
Closes #1185
💚 How did you test it?
Updated tests
📝 Checklist