Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: analyzer action changes #1109

Merged
merged 5 commits into from
Nov 7, 2022
Merged

ci: analyzer action changes #1109

merged 5 commits into from
Nov 7, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 7, 2022

📜 Description

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@vaind vaind force-pushed the ci/analyzer-action-changes branch 2 times, most recently from 6c94d4c to ff0b6ef Compare November 7, 2022 11:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Base: 90.14% // Head: 95.55% // Increases project coverage by +5.40% 🎉

Coverage data is based on head (6fb6b28) compared to base (8883799).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   90.14%   95.55%   +5.40%     
==========================================
  Files         116        2     -114     
  Lines        3573       45    -3528     
==========================================
- Hits         3221       43    -3178     
+ Misses        352        2     -350     
Impacted Files Coverage Δ
dio/lib/src/failed_request_interceptor.dart
dart/lib/src/default_integrations.dart
dart/lib/src/protocol/sentry_culture.dart
dart/lib/src/transport/rate_limiter.dart
dart/lib/src/protocol/sentry_span.dart
dart/lib/src/protocol/sentry_thread.dart
dart/lib/src/client_reports/discarded_event.dart
dart/lib/src/isolate_error_integration.dart
dart/lib/src/sentry_traces_sampling_decision.dart
dart/lib/src/protocol/sentry_response.dart
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vaind vaind force-pushed the ci/analyzer-action-changes branch from 92cc2b7 to 04d7db5 Compare November 7, 2022 12:30
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 305.16 ms 348.02 ms 42.86 ms
Size 5.94 MiB 6.95 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7758e8 300.12 ms 349.88 ms 49.76 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
ef2f368 350.06 ms 429.44 ms 79.38 ms
3e9fb0e 329.14 ms 359.16 ms 30.02 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
0ceb89c 304.57 ms 357.18 ms 52.61 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms

App size

Revision Plain With Sentry Diff
d7758e8 5.94 MiB 6.95 MiB 1.01 MiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
ef2f368 5.94 MiB 6.89 MiB 975.81 KiB
3e9fb0e 5.94 MiB 6.95 MiB 1.01 MiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
0ceb89c 5.94 MiB 6.95 MiB 1.01 MiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB

@vaind vaind force-pushed the ci/analyzer-action-changes branch from 6fb6b28 to 2693d3e Compare November 7, 2022 13:31
@vaind vaind marked this pull request as ready for review November 7, 2022 13:37
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the refactoring and using workflows.
Thanks for doing this @vaind

@marandaneto marandaneto merged commit 76410c3 into main Nov 7, 2022
@marandaneto marandaneto deleted the ci/analyzer-action-changes branch November 7, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Invertase's Dart analyzer action
3 participants