chore: Bump minimum Xcode version to 13 #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2483 +/- ##
==========================================
- Coverage 88.27% 0.00% -88.28%
==========================================
Files 178 178
Lines 15195 13190 -2005
Branches 5281 4923 -358
==========================================
- Hits 13413 0 -13413
- Misses 1607 13111 +11504
+ Partials 175 79 -96
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
With adding the MetricKit integration, we need to bump the min Xcode version to 13, as MetricKit is unavailable on previous Xcode versions. As Xcode 12 doesn't run on macOS 12, and the current Xcode version is 14, we are OK with that change. With that change, we also have to drop support for building platform-specific framework bundles with Carthage, which was the default for Xcode 11 and below, because the workaround for creating a platform-specific framework bundles only works with Xcode 12. Carthage has encouraged its users to use XCFrameworks since version 0.37.0, released in January 2021. Therefore, it's acceptable to use XCFrameworks for Carthage users.
💡 Motivation and Context
Needed for #2476
💚 How did you test it?
CI
📝 Checklist
🔮 Next steps