Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase SentryCrashMAX_STRINGBUFFERSIZE #2465

Merged

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Nov 29, 2022

📜 Description

Simply change the value from 100.000 to 150.000. This should reduce the instances where we're dropping a crash due to size limit (even though the overall envelope limit is 200.000).

This is the quick fix for that problem.

💡 Motivation and Context

Closes #2463

💚 How did you test it?

Not. What do we want to test here? The 100.000 value was also not tested anywhere as far as I can see.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1245.02 ms 1255.44 ms 10.42 ms
Size 20.75 KiB 383.37 KiB 362.62 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
c9129b6 1231.86 ms 1270.11 ms 38.25 ms
dcac8ad 1238.82 ms 1247.80 ms 8.98 ms
7eee302 1228.73 ms 1241.94 ms 13.21 ms
1ce879f 1258.12 ms 1260.90 ms 2.78 ms
a9db8a6 1199.83 ms 1234.56 ms 34.73 ms
e2cec76 1189.48 ms 1229.84 ms 40.36 ms
fb9f27a 1218.55 ms 1249.17 ms 30.62 ms
cdf9acd 1219.62 ms 1254.80 ms 35.18 ms
909e73a 1217.78 ms 1229.70 ms 11.92 ms
9cb6c52 1201.08 ms 1211.37 ms 10.29 ms

App size

Revision Plain With Sentry Diff
c9129b6 20.75 KiB 381.81 KiB 361.06 KiB
dcac8ad 20.75 KiB 379.11 KiB 358.36 KiB
7eee302 20.75 KiB 374.73 KiB 353.97 KiB
1ce879f 20.75 KiB 381.81 KiB 361.06 KiB
a9db8a6 20.75 KiB 383.37 KiB 362.62 KiB
e2cec76 20.75 KiB 381.81 KiB 361.06 KiB
fb9f27a 20.75 KiB 382.11 KiB 361.36 KiB
cdf9acd 20.75 KiB 383.78 KiB 363.03 KiB
909e73a 20.75 KiB 383.40 KiB 362.65 KiB
9cb6c52 20.75 KiB 382.12 KiB 361.36 KiB

Previous results on branch: fix/2463-increase-SentryCrashMAX_STRINGBUFFERSIZE

Startup times

Revision Plain With Sentry Diff
ac83322 1234.24 ms 1264.86 ms 30.62 ms

App size

Revision Plain With Sentry Diff
ac83322 20.75 KiB 383.40 KiB 362.65 KiB

Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

…ERSIZE

* 8.0.0:
  fix: SentryAppStateManager should always stop when closing the SDK (#2460)
  Merge branch 'master' into 8.0.0
  release: 7.31.3
  fix: Reporting crashes when restarting the SDK (#2440)
  Update integration-tests.yml (#2461)
  fix: Core data span status with error (#2439)
  meta: disable swiftlint file length check in TBDBClient.swift (#2435)
  Revert "test: shorten some tests (#2422)" (#2427)
  test: shorten some tests (#2422)
@kevinrenskers kevinrenskers merged commit 2ac6715 into 8.0.0 Nov 30, 2022
@kevinrenskers kevinrenskers deleted the fix/2463-increase-SentryCrashMAX_STRINGBUFFERSIZE branch November 30, 2022 07:09
@philipphofmann
Copy link
Member

Thanks, @kevinrenskers. This could partly solve #2258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants