Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Rename of User to SentryUser #2462

Merged
merged 1 commit into from
Nov 29, 2022
Merged

revert: Rename of User to SentryUser #2462

merged 1 commit into from
Nov 29, 2022

Conversation

brustolin
Copy link
Contributor

Reverted renaming of User to SentryUser

#skip-changelog

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1205.42 ms 1244.42 ms 39.00 ms
Size 20.75 KiB 383.40 KiB 362.65 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
68094b3 1214.14 ms 1255.09 ms 40.95 ms
909e73a 1217.78 ms 1229.70 ms 11.92 ms
1ce879f 1258.12 ms 1260.90 ms 2.78 ms
dcac8ad 1238.82 ms 1247.80 ms 8.98 ms
7eee302 1228.73 ms 1241.94 ms 13.21 ms
c9129b6 1231.86 ms 1270.11 ms 38.25 ms
3fdb749 1227.42 ms 1248.48 ms 21.06 ms
d10145a 1232.65 ms 1257.55 ms 24.90 ms
e2cec76 1189.48 ms 1229.84 ms 40.36 ms
cdf9acd 1219.62 ms 1254.80 ms 35.18 ms

App size

Revision Plain With Sentry Diff
68094b3 20.75 KiB 373.94 KiB 353.19 KiB
909e73a 20.75 KiB 383.40 KiB 362.65 KiB
1ce879f 20.75 KiB 381.81 KiB 361.06 KiB
dcac8ad 20.75 KiB 379.11 KiB 358.36 KiB
7eee302 20.75 KiB 374.73 KiB 353.97 KiB
c9129b6 20.75 KiB 381.81 KiB 361.06 KiB
3fdb749 20.75 KiB 383.81 KiB 363.06 KiB
d10145a 20.75 KiB 379.12 KiB 358.36 KiB
e2cec76 20.75 KiB 381.81 KiB 361.06 KiB
cdf9acd 20.75 KiB 383.78 KiB 363.03 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🙏

@brustolin brustolin merged commit 9f8d429 into 8.0.0 Nov 29, 2022
@brustolin brustolin deleted the revert/sentryuser branch November 29, 2022 15:08
kevinrenskers added a commit that referenced this pull request Nov 29, 2022
* 8.0.0:
  Merge branch 'master' into 8.0.0
  release: 7.31.3
  revert rename of sentryuser (#2462)
  fix: Reporting crashes when restarting the SDK (#2440)
  Update integration-tests.yml (#2461)
  fix: Core data span status with error (#2439)
  meta: disable swiftlint file length check in TBDBClient.swift (#2435)
  Revert "test: shorten some tests (#2422)" (#2427)
  test: shorten some tests (#2422)

# Conflicts:
#	Tests/SentryTests/Helper/TestNSNotificationCenterWrapper.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants