Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Errors shortly after SentrySDK.init don't affect the session #2430

Merged
merged 5 commits into from
Nov 23, 2022

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Nov 22, 2022

📜 Description

Errors shortly after SentrySDK.init now do affect the session.

💡 Motivation and Context

Closes #2150

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.79 ms 1248.30 ms 27.51 ms
Size 20.75 KiB 382.12 KiB 361.36 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
4dc66f6 1202.59 ms 1228.34 ms 25.75 ms
dcac8ad 1238.82 ms 1247.80 ms 8.98 ms
7eee302 1228.73 ms 1241.94 ms 13.21 ms
bbe81cb 1257.25 ms 1272.24 ms 14.99 ms
9be1db2 1219.42 ms 1245.66 ms 26.24 ms
d10145a 1232.65 ms 1257.55 ms 24.90 ms
f91714d 1222.06 ms 1247.00 ms 24.94 ms
88ac2c2 1223.04 ms 1243.12 ms 20.08 ms
2ae7db9 1231.37 ms 1239.98 ms 8.61 ms
68094b3 1214.14 ms 1255.09 ms 40.95 ms

App size

Revision Plain With Sentry Diff
4dc66f6 20.75 KiB 381.81 KiB 361.06 KiB
dcac8ad 20.75 KiB 379.11 KiB 358.36 KiB
7eee302 20.75 KiB 374.73 KiB 353.97 KiB
bbe81cb 20.75 KiB 381.81 KiB 361.06 KiB
9be1db2 20.75 KiB 373.94 KiB 353.19 KiB
d10145a 20.75 KiB 379.12 KiB 358.36 KiB
f91714d 20.75 KiB 381.87 KiB 361.12 KiB
88ac2c2 20.75 KiB 373.61 KiB 352.86 KiB
2ae7db9 20.75 KiB 381.87 KiB 361.12 KiB
68094b3 20.75 KiB 373.94 KiB 353.19 KiB

Previous results on branch: fix/2150-errors-before-session-start

Startup times

Revision Plain With Sentry Diff
245ca99 1242.31 ms 1267.41 ms 25.10 ms
acdef76 1230.76 ms 1250.10 ms 19.34 ms

App size

Revision Plain With Sentry Diff
245ca99 20.75 KiB 382.08 KiB 361.33 KiB
acdef76 20.75 KiB 382.07 KiB 361.32 KiB

…) then you don't have to redeclare the property in SentrySession.m; instead, you can just `#include "SentrySession+Private.h""
CHANGELOG.md Show resolved Hide resolved
Tests/SentryTests/SentryHubTests.swift Outdated Show resolved Hide resolved
change yoda conditions
check for enableAutoSessionTracking
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kevinrenskers kevinrenskers merged commit 9cb6c52 into 8.0.0 Nov 23, 2022
@kevinrenskers kevinrenskers deleted the fix/2150-errors-before-session-start branch November 23, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants