Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fixing 'testGetCaptureFailedRequestsEnabled' #2366

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

brustolin
Copy link
Contributor

testGetCaptureFailedRequestsEnabled should fail and not crash when the test server is not running.

#skip-changelog

Copy link
Contributor

@kevinrenskers kevinrenskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 062f06c into master Nov 7, 2022
@brustolin brustolin deleted the test/fix-http-error-capture-test branch November 7, 2022 10:32
@philipphofmann
Copy link
Member

Thank you @brustolin 💯

kevinrenskers added a commit that referenced this pull request Nov 9, 2022
* master:
  chore: Add match_local to Fastfile
  Revert "feat: Track usage of the enableCaptureFailedRequests option (#2368)" (#2371)
  chore: Remove PrivateSentrySDKOnly.h from umbrella header (#2349)
  feat: Track usage of the enableCaptureFailedRequests option (#2368)
  Update SentryNetworkTrackerIntegrationTests.swift (#2366)
  Fix typos in NetworkTrackerIntegrationTests (#2367)
  build(deps): bump github/codeql-action from 2.1.30 to 2.1.31 (#2364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants