-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo Options initWithDict removal #2547
Comments
If RN is the only one now using this code, it makes sense to me that they added the code we removed. Why add it back here? (Also, why don't they just use the options object and set properties, instead of working with the dict?) |
That makes sense. But why do they even use it in the first place? |
philipphofmann
added a commit
that referenced
this issue
Jan 5, 2023
Add SentryOptions:initWithDict only for Hybrid SDKs again. Fixes GH-2547
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Undo #2404 because hybrid SDKs need to add now the code we removed with #2404; see React-Native. Make
initWithDict
only visible to hybrid SDKs though viaPrivateSentrySDKOnly
.RN are the only ones using
initWithDict
at the moment. Maybe it's better to move the code removed in #2404 to the RN repo including tests.The text was updated successfully, but these errors were encountered: