Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken test testANRDetected_UpdatesAppStateToTrue #2522

Closed
kevinrenskers opened this issue Dec 13, 2022 · 0 comments · Fixed by #2526
Closed

Fix broken test testANRDetected_UpdatesAppStateToTrue #2522

kevinrenskers opened this issue Dec 13, 2022 · 0 comments · Fixed by #2526
Labels
Platform: Cocoa Type: Flaky Test

Comments

@kevinrenskers
Copy link
Contributor

kevinrenskers commented Dec 13, 2022 •
edited
Loading

Description

It's been disabled for a while now, but we had no issue yet to actually fix it.

It's not a flaky test btw, it always fails, also locally.
@kevinrenskers kevinrenskers changed the title Fix flaky test testANRDetected_UpdatesAppStateToTrue Fix broken test testANRDetected_UpdatesAppStateToTrue Dec 13, 2022
@kevinrenskers kevinrenskers changed the title Fix broken test testANRDetected_UpdatesAppStateToTrue Fix broken test testANRDetected_UpdatesAppStateToTrue Dec 13, 2022
kevinrenskers added a commit that referenced this issue Dec 13, 2022
@kevinrenskers
Fix and reenable testANRDetected_UpdatesAppStateToTrue
bceffcb 
- The test calls `SentryWatchdogTerminationTrackingIntegration.anrDetected`.
- This calls `self.appStateManager.updateAppState`, but that uses the TestFileManager under the hood!
- `updateAppState` fails because `[self.fileManager readAppState]` returns `nil`.

Closes #2522

#skip-changelog
@kevinrenskers kevinrenskers mentioned this issue Dec 13, 2022
Merged
5 tasks
@philipphofmann philipphofmann moved this to Needs Discussion in Mobile & Cross Platform SDK Dec 13, 2022
Repository owner moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform: Cocoa Type: Flaky Test
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and reenable testANRDetected_UpdatesAppStateToTrue getsentry/sentry-cocoa
1 participant
@kevinrenskers