We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS
Manually
7.31.2
SentrySDK.close
No OOM in Sentry.
The OutOfMemoryTracker correctly calls stop on the AppStateManager
AppStateManager
sentry-cocoa/Sources/Sentry/SentryOutOfMemoryTracker.m
Line 101 in 907d2ce
but the AppStateManager.stop doesn't modify the app state
AppStateManager.stop
sentry-cocoa/Sources/Sentry/SentryAppStateManager.m
Lines 87 to 118 in 907d2ce
Then the OOMLogic things the app didn't terminate properly cause wasTerminated is not set
sentry-cocoa/Sources/Sentry/SentryOutOfMemoryLogic.m
Lines 77 to 80 in 907d2ce
We could solve this by adding an extra property to the AppState called wasSDKRunning, and only report OOMs if this property is true.
wasSDKRunning
true
The SDK reports an OOM to Sentry.
The text was updated successfully, but these errors were encountered:
I'm happy to pick this up, goes perfectly with #2460.
Sorry, something went wrong.
All the logic is in place for #2457
650c1f0
kevinrenskers
No branches or pull requests
Platform
iOS
Installed
Manually
Version
7.31.2
Steps to Reproduce
SentrySDK.close
Expected Result
No OOM in Sentry.
The OutOfMemoryTracker correctly calls stop on the
AppStateManager
sentry-cocoa/Sources/Sentry/SentryOutOfMemoryTracker.m
Line 101 in 907d2ce
but the
AppStateManager.stop
doesn't modify the app statesentry-cocoa/Sources/Sentry/SentryAppStateManager.m
Lines 87 to 118 in 907d2ce
Then the OOMLogic things the app didn't terminate properly cause wasTerminated is not set
sentry-cocoa/Sources/Sentry/SentryOutOfMemoryLogic.m
Lines 77 to 80 in 907d2ce
We could solve this by adding an extra property to the AppState called
wasSDKRunning
, and only report OOMs if this property istrue
.Actual Result
The SDK reports an OOM to Sentry.
The text was updated successfully, but these errors were encountered: