Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky SentryHttpTransportTests.testFlush_CalledMultipleTimes_ImmediatelyReturnsFalse #2340

Closed
armcknight opened this issue Oct 28, 2022 · 1 comment
Closed

Flaky SentryHttpTransportTests.testFlush_CalledMultipleTimes_ImmediatelyReturnsFalse #2340

armcknight opened this issue Oct 28, 2022 · 1 comment
Assignees
@philipphofmann @brustolin
Labels
Platform: Cocoa Type: Flaky Test

Comments

@armcknight
Copy link
Member

armcknight commented Oct 28, 2022 •
edited
Loading

GitHub action Run Link

https://github.com/getsentry/sentry-cocoa/actions/runs/3342304891/jobs/5534412242#step:9:42

Disabling PR

#2339

Description

Passed in https://github.com/getsentry/sentry-cocoa/actions/runs/3342304891/jobs/5546207690
@bruno-garcia bruno-garcia moved this to Needs Discussion in Mobile & Cross Platform SDK Oct 28, 2022
@brustolin brustolin moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Nov 2, 2022
@brustolin brustolin self-assigned this Nov 2, 2022
@philipphofmann philipphofmann self-assigned this Nov 8, 2022
@philipphofmann philipphofmann moved this from Backlog to In Progress in Mobile & Cross Platform SDK Nov 8, 2022
philipphofmann added a commit that referenced this issue Nov 8, 2022
@philipphofmann
fix: Too long flush duration
ce97c7e 
Move calculation of the flush dispatch time to the beginning of the
flush function to avoid any code until the call to dispatch_group_wait
adds up to the total flush duration.

Fixes GH-2334, GH-2340
@philipphofmann philipphofmann mentioned this issue Nov 8, 2022
Merged
5 tasks
philipphofmann added a commit that referenced this issue Nov 10, 2022
@philipphofmann
fix: Too long flush duration (#2370)
e2a3f3e 
Move the calculation of the flush dispatch time to the beginning of the
flush function to avoid any code until the call to dispatch_group_wait
adds up to the total flush duration.

Fixes GH-2334, GH-2340
@philipphofmann
Copy link
Member

Was fixed with #2370.

Repository owner moved this from In Progress to Done in Mobile & Cross Platform SDK Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

@brustolin brustolin

Labels
Platform: Cocoa Type: Flaky Test
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philipphofmann @armcknight @brustolin