Merge 74bc2e1 into 9754750

getsentry · Nov 14, 2022 · bba6cd3 · bba6cd3
2 parents 9754750 + 74bc2e1
commit bba6cd3
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 36 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 ### Fixes
 
 - Too long flush duration (#2370)
+- Do not delete the app state when OOM tracking is disabled (#2382)
 
 ## 7.30.2
 

diff --git a/Sources/Sentry/SentryAppStateManager.m b/Sources/Sentry/SentryAppStateManager.m
@@ -114,8 +114,6 @@ - (void)stop
             removeObserver:self
                       name:SentryNSNotificationCenterWrapper.willTerminateNotificationName
                     object:nil];
-
-        [self deleteAppState];
     }
 }
 
@@ -124,7 +122,6 @@ - (void)dealloc
     // In dealloc it's safe to unsubscribe for all, see
     // https://developer.apple.com/documentation/foundation/nsnotificationcenter/1413994-removeobserver
     [NSNotificationCenter.defaultCenter removeObserver:self];
-    [self deleteAppState];
 }
 
 /**
@@ -199,11 +196,6 @@ - (void)storeCurrentAppState
     [self.fileManager storeAppState:[self buildCurrentAppState]];
 }
 
-- (void)deleteAppState
-{
-    [self.fileManager deleteAppState];
-}
-
 #endif
 
 @end
diff --git a/Sources/Sentry/include/SentryAppStateManager.h b/Sources/Sentry/include/SentryAppStateManager.h
@@ -35,8 +35,6 @@ SENTRY_NO_INIT
 
 - (void)storeCurrentAppState;
 
-- (void)deleteAppState;
-
 - (void)updateAppState:(void (^)(SentryAppState *))block;
 
 #endif

diff --git a/Tests/SentryTests/Helper/SentryAppStateManagerTests.swift b/Tests/SentryTests/Helper/SentryAppStateManagerTests.swift
@@ -65,39 +65,14 @@ class SentryAppStateManagerTests: XCTestCase {
         XCTAssertNil(fixture.fileManager.readAppState())
     }
 
-    func testStopDeletesAppState() {
+    func testStopDoesNotDeleteAppState() {
         XCTAssertNil(fixture.fileManager.readAppState())
 
         sut.start()
         XCTAssertNotNil(fixture.fileManager.readAppState())
 
-        sut.stop()
-        XCTAssertNil(fixture.fileManager.readAppState())
-    }
-
-    func testStopOnlyRunsLogicWhenStartCountBecomesZero() {
-        XCTAssertNil(fixture.fileManager.readAppState())
-
-        sut.start()
-        XCTAssertNotNil(fixture.fileManager.readAppState())
-
-        sut.start()
-
         sut.stop()
         XCTAssertNotNil(fixture.fileManager.readAppState())
-
-        sut.stop()
-        XCTAssertNil(fixture.fileManager.readAppState())
-    }
-
-    func testStoreAndDeleteAppState() {
-        XCTAssertNil(fixture.fileManager.readAppState())
-
-        sut.storeCurrentAppState()
-        XCTAssertNotNil(fixture.fileManager.readAppState())
-
-        sut.deleteAppState()
-        XCTAssertNil(fixture.fileManager.readAppState())
     }
 
     func testUpdateAppState() {
-Original file line number
+Diff line change
@@ Expand Up / @@ -35,8 +35,6 @@ SENTRY_NO_INIT @@
     - (void)storeCurrentAppState;
-    - (void)deleteAppState;
     - (void)updateAppState:(void (^)(SentryAppState *))block;
     #endif
@@ Expand Down @@