Feat: Capacitor v7 support #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-25
to
+32
| if capacitorVersion.start_with?("2.") or capacitorVersion.start_with?("3.") | ||
| miniOSVersion = '12.0' | ||
| majorVersion = capacitorVersion.split('.').first.to_i | ||
|
|
||
| if majorVersion <= 3 | ||
| miniOSVersion = '12.0' # Capacitor 3, 2. | ||
| elsif majorVersion < 7 | ||
| miniOSVersion = '13.0' # Capacitor 6 or older. | ||
| else | ||
| miniOSVersion = '13.0' # Required for Capacitor 4 and newer. | ||
| miniOSVersion = '14.0' # Capacitor 7 or higher. |
There was a problem hiding this comment.
Does the Capacitor V7 fail to build without the matching minimum target?
I would have expected that a library could specify an older target than the framework, but I see that they say to match the target when upgrading the plugins.
There was a problem hiding this comment.
it did for me, the sdk was set with min iOS version 13 and it was complaining that the project required version 14.
* v7 sample * locks
|
Dependency Review failed with issues in regard to the new sample, those issues will not impact the user code so I will only take actions about it after the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #832
Fixes: #830
This PR adds support for Capacitor V7 to the SDK.
No break changes were introduced.