Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: RewriteFrames on SDK Bump #572

Merged
merged 29 commits into from
Feb 23, 2024
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Feb 12, 2024

This PR does the following tasks:

  • Fixed break change with Rewrite frames.
  • Refactored and relocated most of the tests from RewriteFrames to an unique file, where the sdk test will only validate the integration is being added.
  • Added a new "broken" node library sample for testing stack traces coming from a node module.

#skip-changelog (it will be included on the main PR).
Sub-Task of #573

@lucas-zimerman lucas-zimerman changed the title Add tests, fix errors and enhance sample Fix: RewriteFrames on SDK Bump Feb 12, 2024
@lucas-zimerman lucas-zimerman changed the base branch from feat/client to bump/7.100.1 February 15, 2024 16:50
@lucas-zimerman lucas-zimerman marked this pull request as ready for review February 15, 2024 18:10
…ue build script, removed tests for the removed code
lucas-zimerman and others added 7 commits February 20, 2024 23:25
Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LG 🚀

@lucas-zimerman lucas-zimerman merged commit 3ad5827 into bump/7.100.1 Feb 23, 2024
7 checks passed
@lucas-zimerman lucas-zimerman deleted the fix/rewriteframes branch February 23, 2024 12:03
lucas-zimerman added a commit that referenced this pull request Mar 5, 2024
* chore: update scripts/update-javascript.sh to 7.93.0

* fix most internal break changes

* fix samples with correct sentry version, add client

* fix tests

* update/test samples on windows

* validate on macos

* add description

* rollback to 7931

* remove client

* code cleanup

* Fix: RewriteFrames on SDK Bump (#572)

* Add tests, fix errors and enhance sample

* fix working path

* test

* remove working directory

* add sample

* add test

* test

* fix sample path

* ignore cli errors

* fix hybridsdk

* update lock

* wrong slash

* update samples

* small fixes

* test

* test

* missing esm

* test

* oops

* removed unused Native Linked Errors integration, also fixed missing vue build script, removed tests for the removed code

* Update test/integrations/rewriteframes.test.ts

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>

* Update test/integrations/rewriteframes.test.ts

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>

* remove client

* Add capacitor production tests

* removed unrelated tests

* add development test

* Update src/integrations/rewriteframes.ts

---------

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>

* requested changes

* Update scripts/update-javascript.sh

* apply requested changes

---------

Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants