Feat: Add support of client report #552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
…pacitor into feat/client-report
| version: SDK_VERSION, | ||
| }, | ||
| ]); | ||
| /* TODO: Fix SDKInfo |
There was a problem hiding this comment.
L: From what I see this is unrelated to the PR, looks like only the indentation changed.
What needs to be fixed with SDKInfo?
There was a problem hiding this comment.
Yeah only the indentation changed.
I made a PR only for SDKInfo separately just to avoid fixing everything on a single PR.
It's basically missing the default export from the SDK on the integration.
krystofwoldrich
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the support of Client Report to Sentry Capacitor
#skip-changelog