Bump Android SDK & Set Native/Android SDK Name on crashes #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
commented
Jul 6, 2023
|
It looks good, but I've noticed some differences between how metadata are handled on RN and here in Capacitor. We will have to adjust the implementation to work the same in Capacitor. |
Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Bumps Android SDK to version 6.19. Additionally, it also sets the native and android SDK names as
sentry.java.android.capacitorsentry.native.android.capacitorsentry.cocoa.capacitorAnd by changing the SdkInfo, I also added tests for the sdkinfo logic since it was missing.
Sample events:
android
https://sentry-sdks.sentry.io/issues/4278229145/events/9e681ea435654a4ca16cae8e47134ff0/
ios
https://sentry-sdks.sentry.io/issues/4297593626/events/b30ea4807af54e67aff20fef5b0a30e3
Close #379