fix: disable native if DSN is not provided (#584)

getsentry · Mar 18, 2024 · f2aaf6f · f2aaf6f
1 parent c6eb566
commit f2aaf6f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Fixes
+
+- Native integration would not properly disable when no DSN was provided ([#584](https://github.com/getsentry/sentry-capacitor/pull/584))
+
 ## 0.16.0
 
 ### Features

diff --git a/src/wrapper.ts b/src/wrapper.ts
@@ -82,6 +82,8 @@ export const NATIVE = {
       logger.warn(
         'Warning: No DSN was provided. The Sentry SDK will be disabled. Native SDK will also not be initalized.',
       );
+
+      this.enableNative = false;
       return false;
     }
 

diff --git a/test/wrapper.test.ts b/test/wrapper.test.ts
@@ -163,6 +163,14 @@ describe('Tests Native Wrapper', () => {
         'Note: Native Sentry SDK is disabled.',
       );
     });
+
+    test('sets enableNative: false when dsn is undefined', async () => {
+      await NATIVE.initNativeSdk({
+        dsn: undefined,
+      });
+
+      expect(NATIVE.enableNative).toBe(false);
+    });
   });
 
   describe('sendEnvelope', () => {