Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fix: timestamp with millis from react-native should be in UTC format #456

Merged
merged 2 commits into from
Jun 14, 2020
Merged

fix: timestamp with millis from react-native should be in UTC format #456

merged 2 commits into from
Jun 14, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 12, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fix: timestamp with millis from react-native should be already in UTC format

💡 Motivation and Context

timestamps were off in react-native events if not UTC.

💚 How did you test it?

unit test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

release a new sentry-react-native version.

@marandaneto marandaneto requested a review from HazAT June 12, 2020 06:46
@marandaneto marandaneto changed the title fix: timestamp with millis from react-native should be already in UTC format fix: timestamp with millis from react-native should be in UTC format Jun 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #456   +/-   ##
=========================================
  Coverage     60.26%   60.26%           
  Complexity      816      816           
=========================================
  Files            93       93           
  Lines          3727     3727           
  Branches        359      359           
=========================================
  Hits           2246     2246           
  Misses         1328     1328           
  Partials        153      153           
Impacted Files Coverage Δ Complexity Δ
...y-core/src/main/java/io/sentry/core/DateUtils.java 52.38% <44.44%> (ø) 4.00 <3.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82eac66...c2832d7. Read the comment docs.

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…idSerializerTest.kt

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@marandaneto marandaneto merged commit 4b61453 into getsentry:master Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants