Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

fix: make NoOpLogger public #425

Merged
merged 1 commit into from
May 20, 2020
Merged

fix: make NoOpLogger public #425

merged 1 commit into from
May 20, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 20, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

make NoOpLogger public

💡 Motivation and Context

SentryAndroid.init(applicationContext) { options ->
  options.setLogger(null)
}

Still logs a few thing that runs before the OptionsConfiguration.configure.

one may need to SentryAndroid.init(context, NoOpLogger.getInstance()) if they want a total radio silence.

The other way would be to implement ILogger on its own that does nothing aka NoOp.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@marandaneto marandaneto requested a review from bruno-garcia as a code owner May 20, 2020 11:38
@marandaneto marandaneto requested a review from ninniuz May 20, 2020 11:41
@marandaneto marandaneto changed the title make NoOpLogger public fix: make NoOpLogger public May 20, 2020
Copy link

@ninniuz ninniuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@codecov-commenter
Copy link

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #425   +/-   ##
=========================================
  Coverage     60.04%   60.04%           
  Complexity      813      813           
=========================================
  Files            93       93           
  Lines          3742     3742           
  Branches        363      363           
=========================================
  Hits           2247     2247           
  Misses         1339     1339           
  Partials        156      156           
Impacted Files Coverage Δ Complexity Δ
...-core/src/main/java/io/sentry/core/NoOpLogger.java 100.00% <ø> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce5093...4c765eb. Read the comment docs.

@marandaneto marandaneto merged commit a539fba into getsentry:master May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants