Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention our plan to follow up with v6 soonish #830

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Mention our plan to follow up with v6 soonish #830

merged 2 commits into from
Jan 28, 2025

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jan 28, 2025 •
edited
Loading

#skip-changelog

📜 Description

Mention our plan to follow up with v6 soonish and link to #825

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3cb7447

kahest
kahest approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! left small wording suggestions

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@adinauer @kahest
Apply suggestions from code review
3cb7447 
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@adinauer adinauer merged commit ce74481 into main Jan 28, 2025
20 checks passed
@adinauer adinauer deleted the feat/v5-changelog branch January 28, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahest kahest kahest approved these changes

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @kahest