Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin for spring-dependency-management 1.1.6 #741

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Jul 26, 2024

📜 Description

Fix plugin for spring-dependency-management 1.1.6.

In the new version of spring-depenency-management some of their action are now executed earlier, causing our install strategies to be executed before the AutoInstallState is correctly initialized.

💡 Motivation and Context

Fixes #735

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbloder lbloder marked this pull request as ready for review July 29, 2024 11:07
@lbloder lbloder merged commit 996b045 into main Jul 29, 2024
20 checks passed
@lbloder lbloder deleted the fix/spring-dep-management-1.1.6 branch July 29, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies are not included when using spring-depdency-management 1.1.6
2 participants