-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure sentry-cli works well with configuration cache #675
Conversation
?.substringAfter("[sentry] Using memoized cli path:") | ||
?.trim() | ||
|
||
val cli = File(cliPath!!).also { it.delete() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we still have a test that deletes sentry-cli and then run the build again to verify it does not fail, but extracts the cli again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just left one comment about a test.
And also, would be great if we test that after updating the cli/gradleplugin version it uses the new version instead of an old one. idk if we can easily create a test for that, but verifying it locally would be enough already
… cache enabled runs
…ntry-android-gradle-plugin into fix/sentry-cli-config-cache
it just wasted 2 days of mine. but glad to fixed |
📜 Description
Fixes #651
Fixes #670
Going from
to
💡 Motivation and Context
Our Gradle plugin should be cache-friendly.
💚 How did you test it?
📝 Checklist
🔮 Next steps