Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VisitorTest fixture for MlKitContentProvider bug #620

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 28, 2023

#skip-changelog

Tested it locally with #619 reverted and it was failing with the actual reason that we've fixed:

Instrumented class verification failed with the following exception:
org.objectweb.asm.tree.analysis.AnalyzerException: Error at instruction 21: Argument 1: expected Landroid/content/ContentProvider;, but found Landroid/content/Context;
	at org.objectweb.asm.tree.analysis.Analyzer.analyze(Analyzer.java:292)
	at org.objectweb.asm.util.CheckClassAdapter.verify(CheckClassAdapter.java:1079)
	at io.sentry.android.gradle.instrumentation.VisitorTest.instrumented class passes Java verifier(VisitorTest.kt:82)

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding!

@romtsn romtsn merged commit bf0e24a into main Dec 29, 2023
16 checks passed
@romtsn romtsn deleted the rz/chore/mlkit-contentprovider-test branch December 29, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants