Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider user-defined sentry integration versions when auto-installing and print a warning #602

Merged
merged 38 commits into from
Dec 4, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 29, 2023

📜 Description

  • Do not consider user-defined sentry integrations when auto-installing anymore. This is necessary because we want to align integrations versions to the same one as sentry-android-core or sentry or sentry-android is. Only if the user has directly defined one of the core versions, we will use that to install integrations, otherwise sentryVersion is used.

This means if the user has defined something like that:

// direct deps
dependencies {
  implementation 'io.sentry:sentry-android-core:7.0.0'
  implementation 'io.sentry:sentry-android-okhttp:6.34.0'
}

// or with the gradle plugin
sentry {
  autoInstallation.sentryVersion = '7.0.0'
}

dependencies {
  implementation 'io.sentry:sentry-android-okhttp:6.34.0'
}

Then in both cases it will use 7.0.0 for the -okhttp integration

  • We also print a warning if we have overridden user-defined version to a newer one
  • Change mocked backend as the old one was not available
  • Do not report errors to Sentry when running tests (telemetry)

💡 Motivation and Context

Closes #324

💚 How did you test it?

Manually + automated

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • [] No breaking changes

🔮 Next steps

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn merged commit 994a5de into main Dec 4, 2023
16 checks passed
@romtsn romtsn deleted the rz/feat/autoinstall-override branch December 4, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractInstallStrategy should warn the user about a new sentry-something version installed
2 participants