Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable source context tasks if not enabled #536

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

adinauer
Copy link
Member

📜 Description

Use afterEvaluate to disable source context tasks. Wasn't able to not add them depending on the value of includeSourceContext as that wasn't available yet.

💡 Motivation and Context

Fixes #525

💚 How did you test it?

Manually using Spring sample and unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@adinauer adinauer requested review from markushi and romtsn as code owners July 31, 2023 10:15
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM!

@adinauer adinauer merged commit fcb1cbb into main Aug 2, 2023
@adinauer adinauer deleted the fix/no-api-call-if-source-context-disabled branch August 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When building locally the plugin should not interact with the Sentry API when no auth token is configured
3 participants