Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Okhttp v3 was not instrumented #351

Merged
merged 3 commits into from
Jul 18, 2022
Merged

fix: Okhttp v3 was not instrumented #351

merged 3 commits into from
Jul 18, 2022

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jul 18, 2022 •
edited
Loading

📜 Description

The Okhttp version 3.x hasn't been instrumented because the class was located in a different folder. This PR fixes it by instrumenting both old and new location.

💡 Motivation and Context

💚 How did you test it?

Manually and automated with integration test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@romtsn romtsn requested a review from adinauer as a code owner July 18, 2022 09:34
@romtsn romtsn force-pushed the fix/okhttp-v3-instr branch from 948db7e to 56368e1 Compare July 18, 2022 09:35
@romtsn romtsn changed the title chore: update plugin-build/sentry-cli.properties to 2.3.1 fix: Okhttp v3 was not instrumented Jul 18, 2022
@romtsn romtsn merged commit 29752ad into main Jul 18, 2022
@romtsn romtsn deleted the fix/okhttp-v3-instr branch July 18, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romtsn @adinauer