fix: Okhttp-integration version check #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
If the auto-installation feature is disabled, okhttp instrumentation would crash the app (if there were no okhttp integration on the classpath), because we were checking for the wrong dependency (
sentry-android-core
instead ofsentry-android-okhttp
).Now we just collect all the
io.sentry
dependencies and persists them in a map to later check for the respective module version when selecting instrumentables.💡 Motivation and Context
Closes #326
💚 How did you test it?
Manually and unit + integration tests
📝 Checklist
🔮 Next steps