Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use alpine for nginx and upgrade nginx from 1.16 to 1.21 #974

Closed
wants to merge 1 commit into from
Closed

Conversation

williamdes
Copy link
Contributor

@williamdes williamdes commented May 29, 2021

  • Use alpine for postgres
  • Use alpine for nginx
  • Upgrade nginx from 1.16 to 1.21

NOTE: I did not dare to change the version of clickhouse, but it could use 21.3.12-alpine if you allow the version to be changed.
Since there is no comment on why the version is so much specific (20.3.9.70) and that the clickhouse changelogs are way to large and need expertise I did not change anything.

Possible upgrades:

  • PostgreSQL
  • memcached
  • redis

Ref: #950

@williamdes williamdes changed the title chore: Use alpine for postgres and nginx and upgrade nginx from 1.16 to 1.21 Use alpine for postgres and nginx and upgrade nginx from 1.16 to 1.21 May 29, 2021
@williamdes williamdes changed the title Use alpine for postgres and nginx and upgrade nginx from 1.16 to 1.21 chore: Use alpine for postgres and nginx and upgrade nginx from 1.16 to 1.21 May 30, 2021
@BYK
Copy link
Member

BYK commented May 30, 2021

NOTE: I did not dare to change the version of clickhouse, but it could use 21.3.12-alpine if you allow the version to be changed.
Since there is no comment on why the version is so much specific (20.3.9.70) and that the clickhouse changelogs are way to large and need expertise I did not change anything.

We need to stick to this specific version as it is what we use everywhere else. We are aware of breaking changes in v21 so we cannot upgrade to that one.

I'm okay with the Nginx change but not so sure about Postgres. We'd also need to change some CDC stuff @fpacifici added for postrges so I'd make this PR only on Nginx.

@fpacifici - are you aware of any reason why we were using Alpine in some places? I remember talking about switching self-hosted to Alpine too but then deciding against it but don't remember why, do you remember? 😀

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @williamdes. Just requesting changes regarding the Postgres change.

@williamdes williamdes changed the title chore: Use alpine for postgres and nginx and upgrade nginx from 1.16 to 1.21 chore: Use alpine for nginx and upgrade nginx from 1.16 to 1.21 Jun 2, 2021
@williamdes williamdes requested a review from BYK June 2, 2021 19:51
@BYK BYK changed the title chore: Use alpine for nginx and upgrade nginx from 1.16 to 1.21 ref: Use alpine for nginx and upgrade nginx from 1.16 to 1.21 Jun 2, 2021
@BYK BYK enabled auto-merge (squash) June 2, 2021 19:53
@williamdes
Copy link
Contributor Author

Seems like something is wrong with "service" I suspect it to be a command that needs to be adjusted for alpine

@BYK
Copy link
Member

BYK commented Jun 2, 2021

Seems like something is wrong with "service" I suspect it to be a command that needs to be adjusted for alpine

Eh, glad we have tests 😁

auto-merge was automatically disabled June 19, 2021 22:19

Head branch was pushed to by a user without write access

@BYK
Copy link
Member

BYK commented Jun 23, 2021

I think #1002 will be superseding this.

@BYK
Copy link
Member

BYK commented Jun 29, 2021

Closing since #1002 landed and surpassed this.

Thanks a lot @williamdes for all your effort both on the issues and here with PRs. 🥳

@BYK BYK closed this Jun 29, 2021
@williamdes
Copy link
Contributor Author

Closing since #1002 landed and surpassed this.

Thanks a lot @williamdes for all your effort both on the issues and here with PRs.

Thanks a lot for your reviews and patience !
I am glad more alpine could enter, looking forward to audit more of this to allow new Sentry to enter in our production env

@williamdes williamdes deleted the alpine branch June 29, 2021 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants