-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Use alpine for nginx and upgrade nginx from 1.16 to 1.21 #974
Conversation
We need to stick to this specific version as it is what we use everywhere else. We are aware of breaking changes in v21 so we cannot upgrade to that one. I'm okay with the Nginx change but not so sure about Postgres. We'd also need to change some CDC stuff @fpacifici added for postrges so I'd make this PR only on Nginx. @fpacifici - are you aware of any reason why we were using Alpine in some places? I remember talking about switching self-hosted to Alpine too but then deciding against it but don't remember why, do you remember? 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @williamdes. Just requesting changes regarding the Postgres change.
Seems like something is wrong with "service" I suspect it to be a command that needs to be adjusted for alpine |
Eh, glad we have tests 😁 |
Head branch was pushed to by a user without write access
I think #1002 will be superseding this. |
Closing since #1002 landed and surpassed this. Thanks a lot @williamdes for all your effort both on the issues and here with PRs. 🥳 |
Thanks a lot for your reviews and patience ! |
Use alpine for postgresNOTE: I did not dare to change the version of clickhouse, but it could use
21.3.12-alpine
if you allow the version to be changed.Since there is no comment on why the version is so much specific (
20.3.9.70
) and that the clickhouse changelogs are way to large and need expertise I did not change anything.Possible upgrades:
Ref: #950