Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdc): Prepare the self hosted environment for the Change Data Capture pipeline #938
feat(cdc): Prepare the self hosted environment for the Change Data Capture pipeline #938
Changes from 6 commits
7b5074d
66844f8
57b2d1a
47e95d6
dbc94c6
d82b216
8844e8d
9d2f8a7
a31b8e1
66d0b0c
47906d9
2f62595
b2a48a9
b10d57c
9e3a60a
a5488d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this script in place, do we still need line 83 above?
Also, since we now control the entrypoint, does it have to live under this specific directory? Because if not, then why not just mount
./postgres
under/opt/sentry
and use everything from there? This would reduce the number of bind mounts to 1 and would avoid file-mounts which we had issues with sometimes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need
POSTGRES_HOST_AUTH_METHOD: "trust"
. That is not about replication while the changes to pg_hba are only about the replication connections.POSTGRES_HOST_AUTH_METHOD changes the standard connections we use to run queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't relied on the availability of
wget
so far (with the exception of our experimental--minimize-downtime
flag). We haven't received any complaints about that but just wanted to double check on whether this is a safe assumption to make or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What bout curl ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same. The only assumptions we make are
bash
,docker
,docker-compose
,sed
,awk
, andgrep
. I think we can find/use acurl
orwget
docker image to be safe :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out I
don'tdidn't havewget
. 😊There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like macOS does ship with
curl
. If we can't find a Docker image easily I think curl would be a safe choice. Do you know of any Linux that doesn't have it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now relying on
curlimages/curl