Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure snuba cleanup job runs on the correct storage #923

Merged
merged 1 commit into from
Apr 14, 2021
Merged

fix: Ensure snuba cleanup job runs on the correct storage #923

merged 1 commit into from
Apr 14, 2021

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Apr 13, 2021 •
edited by BYK
Loading

Follow up to #920.

BYK
BYK approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a cleanup job for transactions storage?

@BYK BYK changed the title feat: Ensure snuba cleanup job runs on the correct storage fix: Ensure snuba cleanup job runs on the correct storage Apr 14, 2021
@BYK BYK merged commit 35a45ea into master Apr 14, 2021
@BYK BYK deleted the cleanup-correct-storage branch April 14, 2021 08:50
@lynnagara
Copy link
Member Author

Do we need a cleanup job for transactions storage?

Yeah, it would be good to add a job for that too

@BYK
Copy link
Member

BYK commented Apr 14, 2021

@lynnagara can you guide me to add that?

@lynnagara
Copy link
Member Author

@BYK The command would be exactly the same as this line, but with --storage transactions instead of --storage errors

@BYK BYK mentioned this pull request Apr 15, 2021
Merged
BYK added a commit that referenced this pull request Apr 15, 2021
@BYK
fix: Add missing snuba transactions clean up service
61b8376 
Follow up to #920 and #923.
BYK added a commit that referenced this pull request Apr 15, 2021
@BYK
fix: Add missing snuba transactions clean up service (#924)
e0dde9c 
Follow up to #920 and #923.
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BYK BYK BYK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lynnagara @BYK