Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(volumes): Fix creation of random volumes at every run #291

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 3, 2019

Plugs all the holes (VOLUME defs) in the images we use so they at least persist across runs/restarts for things like random logs or SMTP spool. This also fixes symbolicator_cleanup service not having access to symbolicator data.

@BYK BYK requested a review from mattrobenolt December 3, 2019 22:27
Plugs all the holes (VOLUME defs) in the images we use so they at least persist across runs/restarts for things like random logs or SMTP spool. This also fixes symbolicator_cleanup service not having access to symbolicator data.
@BYK BYK force-pushed the byk/fix/extra-volumes branch from 9a07ab1 to bafd6a7 Compare December 3, 2019 22:31
@BYK BYK requested a review from mattrobenolt December 3, 2019 22:33
Copy link
Contributor

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually h ave to prefix them all? I feel like docker-compose already adds a prefix to everything to avoid conflicts.

@BYK
Copy link
Member Author

BYK commented Dec 3, 2019

Do you actually h ave to prefix them all? I feel like docker-compose already adds a prefix to everything to avoid conflicts.

It does and uses the directory name as the prefix (onpremise in this case) which is not very descriptive. I'll address this by adding an explicit name to the project in a later PR.

@BYK BYK merged commit 7b10fea into master Dec 3, 2019
@BYK BYK deleted the byk/fix/extra-volumes branch December 3, 2019 23:29
MaicolBen pushed a commit to hinthealth/onpremise that referenced this pull request Jul 20, 2020
)

Plugs all the holes (VOLUME defs) in the images we use so they at least persist across runs/restarts for things like random logs or SMTP spool. This also fixes symbolicator_cleanup service not having access to symbolicator data.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants