Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #109

Closed
wants to merge 2 commits into from
Closed

Conversation

armenak-baburyan
Copy link

Update due previous changes of docker-compose.yml.

Update due previous changes of docker-compose.yml.
README.md Outdated
5. `docker-compose up -d` - Lift all services (detached/background mode).
6. Access your instance at `localhost:9000`!
4. `docker-compose up -d` - Lift all services (detached/background mode).
5. Access your instance at `0.0.0.0:9000`!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I disagree with this one. It doesn’t even make sense to use 0.0.0.0 from the client. I understand it works, but why not localhost anymore? 0.0.0.0 is unlikely to work with everything.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make clear that IP address may be external as well. May be use IP_ADDRESS:9000 instead. localhost led me astray. Any way I can get localhost back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest http://127.0.0.1:9000 which is clickable :)

Change IP address
@lschricke
Copy link

This update looks good to me! 👍

@mattrobenolt
Copy link
Contributor

Is any of this still relevant after #123 ?

@BYK
Copy link
Member

BYK commented Jun 10, 2019

Closing due to inactivity (lack of any responses to @mattrobenolt's latest comment). If anyone thinks we should look into this, please ping and I'll happily reopen.

@BYK BYK closed this Jun 10, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants