Skip to content

Commit

Permalink
fix(clickhouse): Use correct HTTP port for healthcheck (#1069)
Browse files Browse the repository at this point in the history
Should fix #1058
  • Loading branch information
BYK authored Aug 19, 2021
1 parent 7b96408 commit 59c0df3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## Unreleased

- fix(clickhouse): Use correct HTTP port for healthcheck (#1069)
Fixes the regular `Unexpected packet` errors in Clickhouse

## 21.8.0

- feat: Support custom CA roots ([#27062](https://github.com/getsentry/sentry/pull/27062)), see the [docs](https://develop.sentry.dev/self-hosted/custom-ca-roots/) for more details.
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ services:
test:
[
"CMD-SHELL",
"wget -nv -t1 --spider 'http://localhost:9000/' || exit 1",
"wget -nv -t1 --spider 'http://localhost:8123/' || exit 1",

This comment has been minimized.

Copy link
@pharindoko

pharindoko Aug 22, 2021

Contributor

Hey @BYK
snuba will use port 9000 (clickhouse itself). This worked for me perfectly - I assumed at least.
Why you are now waiting for the clickhouse ui being ready ?

br,

pharindoko

This comment has been minimized.

Copy link
@BYK

BYK Aug 23, 2021

Author Member

Port 9000 is not HTTP hence sending HTTP requests there was causing issues in Clickhouse, see #1058 for more details.

Regarding the healthcheck and dependency definitions update, you can check #1033 where it mentions the race-condition we had, causing issues on slower Clickhouse startups.

This comment has been minimized.

Copy link
@pharindoko

pharindoko Sep 1, 2021

Contributor

sorry my fault. thought wget can be used for all tcp ports / connections ...

This comment has been minimized.

Copy link
@BYK

BYK Sep 1, 2021

Author Member

No worries at all 🙂

]
interval: 3s
timeout: 600s
Expand Down

0 comments on commit 59c0df3

Please sign in to comment.