-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add matcher for request headers #407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I only had one small suggestion.
Looks like I messed up on the python 2.7 messages - I'll be honest and admit that I typed them manually and didn't bother checking they were right... I'll update them along with the changes requested this evening. |
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 95.59% 97.76% +2.17%
==========================================
Files 4 4
Lines 1568 1704 +136
==========================================
+ Hits 1499 1666 +167
+ Misses 69 38 -31
Continue to review full report at Codecov.
|
Looks like there are a few conflicts with one of the other recently merged pull requests. Sorry about that. |
Damn, that's what I get for sitting on this for four weeks I guess :) I'll take a look now :) |
5f2c3f4
to
fa35c2f
Compare
thanks to both @beliaev-maksim and @markstory for your input 🙂 I've rebased this against master, changed the param name and squashed things together to tidy up the history. Hopefully it now incorporates everything discussed 👍 |
code implementation looks good to me |
@eviltwin awesome! thanks for this PR! @markstory can this be merged? |
Thank you 👍 |
I needed a matcher for request headers and so I built one that I felt was generic enough to warrant inclusion upstream.
Hopefully the detail that I've added to the README.rst is enough to understand the motivation for how I built it, so I'll avoid repeating myself here.
I'm happy to discuss any changes that you might like in order to have this merged.