Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(store): remove references to feedback topic option after rollout #3604

Closed
wants to merge 4 commits into from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented May 15, 2024

Removing references to this option now that we have successfully rolled out and tested the feedback topic in all regions.

getsentry/sentry#66100
Datadog

#skip-changelog

@aliu39 aliu39 requested a review from a team as a code owner May 15, 2024 22:17
@aliu39 aliu39 changed the title f ref(store): remove references to feedback topic option after rollout May 15, 2024
@aliu39 aliu39 requested a review from a team May 15, 2024 22:18
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I assume this is okay for self hosted as well?

@aliu39
Copy link
Member Author

aliu39 commented May 16, 2024

I assume this is okay for self hosted as well?

Good catch, it's not... have to let the team know and might be some time before we add the topic/consumer there. So I'm gonna hold off on this, but might remove the inline-attachments flag

@aliu39 aliu39 closed this May 16, 2024
@aliu39 aliu39 reopened this May 16, 2024
@aliu39
Copy link
Member Author

aliu39 commented Jun 3, 2024

Had some complications with testing the topic+option in self-hosted - plan to come back to this later

@aliu39 aliu39 closed this Jun 3, 2024
@jan-auer jan-auer deleted the aliu/rm-feedback-topic-option branch July 4, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants