fix(config): Processing is only for managed mode #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Feb 20, 2024
jjbayer
reviewed
Feb 20, 2024
relay/src/setup.rs
Outdated
| @@ -9,6 +9,13 @@ pub fn check_config(config: &Config) -> Result<()> { | |||
| ); | |||
| } | |||
|
|
|||
| if config.relay_mode() == RelayMode::Proxy && config.processing_enabled() { | |||
| anyhow::bail!( | |||
| "Processing mode cannot be enabled while in the proxy mode. \ | |||
There was a problem hiding this comment.
Suggested change
| "Processing mode cannot be enabled while in the proxy mode. \ | |
| "Processing mode cannot be enabled while in proxy mode. \ |
relay/src/setup.rs
Outdated
| if config.relay_mode() == RelayMode::Proxy && config.processing_enabled() { | ||
| anyhow::bail!( | ||
| "Processing mode cannot be enabled while in the proxy mode. \ | ||
| Please disable processing or switch to managed mode." |
There was a problem hiding this comment.
This might incentivize users to enable processing in managed mode, so I would not even mention it here. Side note: Should Processing be a separate mode, i.e. variant of RelayMode, instead of a boolean flag?
Suggested change
| Please disable processing or switch to managed mode." | |
| " |
TBS1996
approved these changes
Feb 20, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy mode should not allow processing to be enabled.
fix: #3048
#skip-changelog