feat(spans): Improve span data http method extraction #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check `http.request.method` and `method` fields when trying to extract `span.action` from an http span.
There was a problem hiding this comment.
The code looks good!
Adding new spans to this test and running it should update a couple of snapshots and the tag should be available in there.
|
Added snapshot tests with d0de357 I also changed |
d0de357 to
2144d6a
Compare
olksdr
approved these changes
Aug 10, 2023
| @@ -200,15 +200,18 @@ pub(crate) fn extract_tags(span: &Span, config: &Config) -> BTreeMap<SpanTagKey, | |||
| .and_then(|data| data.get("description.scrubbed")) | |||
| .and_then(|value| value.as_str()); | |||
|
|
|||
| // TODO(iker): we're relying on the existance of `http.method` | |||
| // TODO(iker): we're relying on the existance of `http.method`/`http.response.method` | |||
There was a problem hiding this comment.
Can we remove this TODO now and just put in the doc string the places we actually look in (and maybe why? E.g. open telemetry scheme etc.), which in my opinion makes more sense.
There was a problem hiding this comment.
Yes I can amend this, good call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
http.request.methodandmethodfields when trying to extractspan.actionfrom an http span.As a we start rolling out getsentry/team-sdks#19 to more SDKs, we updated the span data field for HTTP methods from
http.methodtohttp.request.method. This is to match the new OpenTelemetry conventions.Not sure how to best test this, feedback appreciated!
#skip-changelog