This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 224
default span status if there was an error or http response code does not match any span status code #307
Labels
Comments
4 tasks
for Java, we are changing to: If there's an exception, we set the span status to This only applies to spans created out of HTTP requests |
This was referenced Apr 19, 2021
4 tasks
for non HTTP requests, the span should be finished with |
6 tasks
mentioned here already https://develop.sentry.dev/sdk/features/#http-client-integrations |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to Reproduce
Trigger an unknown HTTP response code (that does not match any span status code) or an exception so span either won't have a status or it'll diverge across SDKs
Expected Result
All SDKs match the default status in such cases:
an exception was thrown, maybe
INTERNAL_ERROR
HTTP response code does not match any span status code, set maybe
UNKNOWN
? we could also make this based on HTTP code range.eg HTTP response code is 502, we don't have such span status code, what's the default for 5xx range?
eg HTTP response code is 402, same as above, what's the default for 4xx range?
This should be aligned across SDKs for a better experience.
Actual Result
Android OkHttp sets
INTERNAL_ERROR
as status if there was an error or HTTP response code does not match span status code;Java Spring sets no status at all;
.NET sets
Unknown
;The text was updated successfully, but these errors were encountered: