This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
feat: Load Python version from .python-version file #34
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow up work from getsentry/sentry#29571
armenzg
commented
Oct 27, 2021
| @@ -6,7 +6,7 @@ on: | |||
| pull_request: | |||
|
|
|||
| jobs: | |||
| bootstrap: | |||
| fast-bootstrap: | |||
There was a problem hiding this comment.
Later on we can add caches and let the slow one take its time.
| @@ -18,6 +18,34 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
|
|
|||
| - name: Execute bootstrap | |||
| env: | |||
| STRAP_DEBUG: 1 | |||
There was a problem hiding this comment.
This is useful in case there's a failure so we can see what command failed.
| @@ -577,7 +577,7 @@ sudo_refresh | |||
| # Before starting, get the user's code location root where we will clone sentry repos to | |||
| get_code_root_path | |||
|
|
|||
| [ -z "$CI" ] && check_github_access | |||
| [ -z "$CI" ] && [ -z "$QUICK" ] && check_github_access | |||
There was a problem hiding this comment.
It's actually a slow step!
| # shellcheck disable=SC1090 disable=SC1091 | ||
| source "${SENTRY_ROOT}/scripts/lib.sh" | ||
| get-pyenv-version | ||
| ) |
armenzg
commented
Oct 27, 2021
billyvg
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up work from
getsentry/sentry#29571