Fix headless mode (didn't work with vertical navbar) #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@kravets-levko I noticed the Public Dashboard page also has some extra spacing now.
Is that intentional or should we take this opportunity to remove some of that?
|
@gabrieldutra Comparing to |
|
@gabrieldutra Yeah, that was an accidental bug as well. Fixed: b047536 |
gabrieldutra
approved these changes
Jun 16, 2020
andrewdever
pushed a commit
to andrewdever/redash
that referenced
this pull request
Oct 5, 2020
* Fix headless mode (didn't work with vertical navbar) * Fix header margins on public dashboard page * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When implementing vertical navbar I forgot to update a headless mode 🤦♂️
Related Tickets & Documents
Related discussion: #4859 (comment)