Fix Execute Selected not working for dirty queries #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
reviewed
Sep 24, 2019
| @@ -42,7 +42,7 @@ function QueryViewCtrl( | |||
| } | |||
|
|
|||
| $scope.showLog = false; | |||
| if ($scope.isDirty) { | |||
| if ($scope.isDirty || !isEmpty(selectedQueryText)) { | |||
There was a problem hiding this comment.
Why is isDirty being checked here actually?
There was a problem hiding this comment.
If the query text wasn't changed we use the results API that takes just the query id (the safe API which requires only read access). If the text was changed, we use the results API that takes SQL (requires full access).
|
@gabrieldutra maybe this could help with ace/cypress cypress-io/cypress#1818 (comment) |
|
@ranbena thanks, that helps with Ace Editor usages in code (avoids having to to use |
|
@gabrieldutra hmm right. Not sure it's worth the effort. |
|
Yep, not as simple, so I'm dropping it |
ranbena
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The Execute Selected was not working when the query wasn't in a "dirty state".
Pending:
Cypress test(?)Not that easy to select a text inside Ace Editor in Cypress 😕Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before
After
