Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the annoying quoted hover from EmptyState #4168

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Sep 22, 2019

  • Bug Fix

Description

<EmptyState> uses a title proptype. When used in conjunction with the title attribute, the result is an annoying hover message which includes the single quotes required by by react2angular.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before:

image

After:

image

#thingsThatNobodyCaresAbout

@rauchy rauchy changed the title remove the annoying quoted title from EmptyState remove the annoying quoted hover from EmptyState Sep 22, 2019
@arikfr arikfr merged commit ed22b63 into master Sep 22, 2019
@arikfr arikfr deleted the remove-quoted-title-from-empty-state branch September 22, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants