Handle Create Dashboard with middle click #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinclift I actually have no way of testing this on my mac.. so approve it if it works from the preview https://deploy-preview-4158--redash-preview.netlify.com. |
49b0373 to
674f483
Compare
There was a problem hiding this comment.
@ranbena, Netlify weirdly seemed to have failed, so I forced it to run again with a temporary commit 🙂.
BTW, it seems the middle click thing didn't work to me 😕.
|
Ok I just realized middleclick doesn't trigger with click event. |
7e65aea to
404ee7c
Compare
arikfr
approved these changes
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4155