Fix eslint errors #3374
Merged
Fix eslint errors #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
reviewed
Jan 31, 2019
| this.setState({ | ||
| preview: markdown.toHTML(this.state.text), | ||
| preview: markdown.toHTML(text), |
There was a problem hiding this comment.
react/no-access-state-in-setstate
ranbena
reviewed
Jan 31, 2019
ranbena
reviewed
Jan 31, 2019
| } | ||
|
|
||
| init.init = true; | ||
|
|
There was a problem hiding this comment.
Ah, I just noticed that this directive is not used anymore (checked twice 😄), so decided to remove it instead of fixing eslint warnings there.
ranbena
approved these changes
Jan 31, 2019
gabrieldutra
approved these changes
Jan 31, 2019
| @@ -47,13 +47,13 @@ export class DynamicForm extends React.Component { | |||
| } | |||
|
|
|||
| setActionInProgress = (actionName, inProgress) => { | |||
| this.setState({ | |||
| this.setState(prevState => ({ | |||
There was a problem hiding this comment.
Cool, I didn't know prevState existed here 😅
There was a problem hiding this comment.
Me too. I just read the docs 😄
There was a problem hiding this comment.
BTW - it's the same warning as @ranbena mentioned above - react/no-access-state-in-setstate
There was a problem hiding this comment.
Also, eslint is smart enough to detect code like this (the same rule):
updateCounter() {
const counter = this.state.counter + 1;
this.setState({ counter });
}(I tried to modify code this way, but warning didn't disappear 😅)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just removed extra empty lines at EoF.
@ranbena and @gabrieldutra There are also some fixes to components you were recently working on, so please check it. Thanks!