Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication related settings improvements #2350

Merged
merged 6 commits into from
Feb 28, 2018
Merged

Authentication related settings improvements #2350

merged 6 commits into from
Feb 28, 2018

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Feb 27, 2018

  • Fix SSO URLs in invite.html.
  • Don't allow disabling Password based login if no SSO is enabled.
  • UI to edit allowed Google Apps domains.

newsettings_demo

@arikfr arikfr requested a review from kravets-levko February 27, 2018 21:17
kravets-levko
kravets-levko approved these changes Feb 28, 2018
View reviewed changes
redash/handlers/authentication.py
@@ -172,7 +173,8 @@ def client_config():
'dateFormat': date_format,
'dateTimeFormat': "{0} HH:mm".format(date_format),
'mailSettingsMissing': settings.MAIL_DEFAULT_SENDER is None,
'dashboardRefreshIntervals': settings.DASHBOARD_REFRESH_INTERVALS
'dashboardRefreshIntervals': settings.DASHBOARD_REFRESH_INTERVALS,
'googleLoginEnabled': settings.GOOGLE_OAUTH_ENABLED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add , after last value - it will be easier to add new keys, and diff will show only them 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will try to remember this for next time.

@arikfr arikfr merged commit bb28b2f into master Feb 28, 2018
@arikfr arikfr deleted the auth branch July 31, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kravets-levko kravets-levko kravets-levko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arikfr @kravets-levko